Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tld: small tweak to parser's handling of superscript #1968

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 23, 2020

Description

Without this, some TLDs like .бел won't be included in the data table.

Originally added while chasing a different (Heisen)bug (#1945), but unlike that bug, this one was reproducible across multiple parses of the wiki page.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Without this, some TLDs like `.бел` won't be included in the data table.

Originally added while chasing a different (Heisen)bug, but unlike that
bug, this one was reproducible across multiple parses of the wiki page.
@dgw dgw added the Tweak label Oct 23, 2020
@dgw dgw added this to the 7.1.0 milestone Oct 23, 2020
@dgw dgw requested a review from a team October 23, 2020 14:10
@dgw dgw merged commit 63c8913 into master Dec 16, 2020
@dgw dgw deleted the tld-parser-superscript-tweak branch December 16, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants