Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irc: test sopel.irc.utils.safe function #1983

Merged
merged 1 commit into from
Dec 27, 2020

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Nov 6, 2020

Description

sopel.irc.utils.safe wasn't tested, now it is. Also with a better docstring.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 7.1.0 milestone Nov 6, 2020
@Exirel Exirel requested a review from a team November 6, 2020 22:43
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward enough, but it seems like something was copied and pasted that needs updating. 😁

test/irc/test_irc_utils.py Outdated Show resolved Hide resolved
@Exirel Exirel force-pushed the irc-test-utils-safe branch from 0179889 to 195b57a Compare November 9, 2020 09:02
@Exirel Exirel requested a review from dgw November 9, 2020 09:03
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Imagine asking for a one-line change and then forgetting about the PR for 6 weeks… 🙊

@dgw dgw merged commit 4414bf9 into sopel-irc:master Dec 27, 2020
@Exirel Exirel deleted the irc-test-utils-safe branch May 1, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants