instagram: remove fragile plugin #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No promises, but the Instagram plugin will be moved to its own repo where someone interested could patch it up to accept an API key. We're just not going to keep it in core long-term, largely because of our ongoing intent to piece out all nonessential plugins so bug fixes don't require a whole Sopel release just because an API changed, and so plugins can be a bit more liberal about extra requirements if their deps only get installed for users who specifically install that plugin.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Instagram plugin will be moved to its own repo where someone interested could patch it up to accept an API key.
Checklist
make qa(runsmake qualityandmake test)Notes
When merging, I (@dgw) will need to take the last "good" version of the plugin (probably c4a812e, which will require Sopel 7.1+ due to use of
bot.say()'s newtrailingparameter) and make a new standalone plugin release from a dedicated repo.Not requesting immediate review; will wait until we "officially" begin work on 8.0.