tests: deprecate test_tools; replace with tests.pytest_plugin #2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
dgw
reviewed
Dec 14, 2020
Exirel
force-pushed
the
tests-deprecate-test-tools
branch
2 times, most recently
from
54ca39f to
d87f998
Compare
|
I did some force-push because really its just a few lines. Damn, I hate |
dgw
reviewed
Dec 15, 2020
|
Already did. |
|
Did you? Without 3f10b01, that first commit introduces mixed indentation (3 & 4 spaces) into the module docstring for |
|
Pretty sure it's fixed... did I do something wrong? I don't see what you are talking about. I remember the problem, but I think I did fixed and rebased properly. |
|
I can even see it on mobile. First commit:
Fix commit, replacing mixed indentation and redundant verbiage with a consistent and concise docstring:
|
|
Oh, OK. Weird. |
Exirel
force-pushed
the
tests-deprecate-test-tools
branch
from
3f10b01 to
b8d5144
Compare
|
OK, now it should be good! |
dgw
approved these changes
Jan 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the last refactoring, the only purpose left for
sopel.test_toolswas to provide utility functions forsopel.plugin.example. Since this feature always requires pytest, I figured that it would be better to nukesopel.test_toolsin Sopel 8 and to move everything still relevant to that plugin.A second round of refactoring in Sopel 8 might be done at some point to rework how pytest is used to discover example test, but that's for another time and certainly not something to do in this PR.
Checklist
make qa(runsmake qualityandmake test)