Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

loader: improve docstrings #2004

Merged
merged 1 commit into from
Jan 12, 2021
Merged

loader: improve docstrings #2004

merged 1 commit into from
Jan 12, 2021

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Dec 14, 2020

Description

This is (hopefully) the last PR needed to close (eventually) #1565, by improving docstrings of sopel.loader.

At some point, I might want to deprecate sopel.loader by moving its best parts in sopel.plugins, but that's another story for another day.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added this to the 7.1.0 milestone Dec 14, 2020
@Exirel Exirel requested a review from dgw December 14, 2020 17:28
@Exirel Exirel mentioned this pull request Dec 14, 2020
Closed
26 tasks
dgw
dgw reviewed Dec 25, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple ideas. Almost hit "Approve" on sight, because it's 99% there.

sopel/loader.py Outdated Show resolved Hide resolved
sopel/loader.py Outdated Show resolved Hide resolved
dgw
dgw approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready for squash 🚀

Edit: Wanted to merge, so squashed myself 10 days later.

@Exirel @dgw
loader: improve docstrings
80ee365 
Co-authored-by: dgw <dgw@technobabbl.es>
@dgw dgw force-pushed the loader-docstrings branch from 35a2062 to 80ee365 Compare January 12, 2021 06:18
@dgw dgw merged commit 0b0d4a5 into sopel-irc:master Jan 12, 2021
@Exirel Exirel deleted the loader-docstrings branch May 1, 2021 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw