rules: add get-all methods for all types of rules #2011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
reviewed
Dec 31, 2020
Co-authored-by: dgw <dgw@technobabbl.es>
Exirel
force-pushed
the
rules-get-all-methods
branch
from
a861bb6 to
847d95d
Compare
|
Rebased & squashed, since it was just typo fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I implemented the new rule system, I made the methods that were necessary to be backward compatible with the bot's doc, which is used by the help plugin, but nothing more.
However, now that I have extended that to all type of rules (including commands and URL callback), it was time to add the appropriate methods for all types of rules.
Checklist
make qa(runsmake qualityandmake test)