Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isupport: return empty CHANMODES if unavailable #2015

Merged
merged 1 commit into from
Jan 17, 2021
Merged

isupport: return empty CHANMODES if unavailable #2015

merged 1 commit into from
Jan 17, 2021

Conversation

half-duplex
Copy link
Member

Description

Reduce boilerplate necessary for plugins that use isupport.CHANMODES by returning {"A": "", ...} instead of raising AttributeError if the server hasn't given us info.
See #1980 (comment)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added this to the 7.1.0 milestone Jan 12, 2021
@half-duplex half-duplex requested a review from Exirel January 12, 2021 21:00
@half-duplex half-duplex mentioned this pull request Jan 12, 2021
Merged
4 tasks
dgw
dgw approved these changes Jan 12, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will await @Exirel's review before merging.

dgw
dgw reviewed Jan 12, 2021
View reviewed changes
test/irc/test_irc_isupport.py Outdated Show resolved Hide resolved
@dgw dgw merged commit 52839c7 into sopel-irc:master Jan 17, 2021
@dgw
Copy link
Member

dgw commented Jan 17, 2021

Merged "out of order" so older, dependent PRs can be updated.

@half-duplex half-duplex deleted the default-chanmodes branch January 17, 2021 22:34
@half-duplex half-duplex restored the default-chanmodes branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@half-duplex @dgw @Exirel