Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reddit: show singular "comment" in post output when appropriate #2025

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jan 28, 2021

Description

Just a grammar issue that's been annoying me for too long already. Tested with a very imaginative "random" Reddit submission ID, 123456 😼

Before (emphasis added):

[reddit] I'm thinking about getting a dog and YouTubed ways to train them. Then I came across this video (http://www.youtube.com/watch?v=b9upM4RbIeU&feature=g-vrec) to r/funny | 0 points (50.0%) | 1 comments | Posted by cocobunny | Created at Thursday, October 25, 2012 15:53:08 -0500

After (emphasis again added):

[reddit] I'm thinking about getting a dog and YouTubed ways to train them. Then I came across this video (http://www.youtube.com/watch?v=b9upM4RbIeU&feature=g-vrec) to r/funny | 0 points (50.0%) | 1 comment | Posted by cocobunny | Created at Thursday, October 25, 2012 15:53:08 -0500

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jan 28, 2021
@dgw dgw added this to the 7.1.0 milestone Jan 28, 2021
@dgw dgw requested a review from a team January 28, 2021 03:57
@dgw dgw merged commit 13a59f8 into master Feb 25, 2021
@dgw dgw deleted the reddit-comments-plural branch February 25, 2021 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants