find: don't output useless bold formatting for empty replacement #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exirel
requested changes
May 15, 2021
|
@Exirel I don't mind having whitespace- or control-code-only changes as edge cases. For the intended class of uses (deleting repeated words or other extra characters), this works just fine, and doesn't introduce any bold formatting where it wasn't already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. I did a
s/something //replacement to delete an extra word recently and realized that the line contained two useless bold formatting bytes anyway, because that's how the logic was written and I didn't think of this case during review of #2014.Checklist
make qa(runsmake qualityandmake test)