Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currency: switch default to exchangerate.host; remove ratesapi.io #2074

Merged
merged 1 commit into from
May 26, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented May 26, 2021

Description

ratesapi.io appears to have been bought, too. exchangerate.host is now the default, and the only keyless API included.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Thanks for buying fucking everything, apilayer, I hate it.

This is why currency will be one of the first plugins I extract to a standalone package in preparation for 8.0. Just keeping it working is becoming a game of reverse whack-a-mole.

exchangerate.host is now the default, and the only keyless API included.
@dgw dgw added the Tweak label May 26, 2021
@dgw dgw added this to the 7.1.0 milestone May 26, 2021
@dgw dgw requested a review from a team May 26, 2021 08:10
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as it work as intended... let's go!

@dgw dgw merged commit 12f8640 into master May 26, 2021
@dgw dgw deleted the another-currency-api-bites-the-dust branch May 26, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants