Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tld: ccTLD data moved to its own wiki page #2076

Merged
merged 1 commit into from
May 28, 2021
Merged

tld: ccTLD data moved to its own wiki page #2076

merged 1 commit into from
May 28, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented May 27, 2021

Description

Instead of fetching one big wiki page with everything in it, we have to fetch the gTLD tables from the same place as before, and then get the ccTLD lists separately.

This could be the first of several splits, since the "List of Internet top-level domains" page has a maintenance tag at the top decrying that it's long and hard to navigate. I've made it rather easy to add more pages if the different types of TLD do continue getting split out into their own pages.

Before/After

SopelTest is this branch; Kaede is current master (12f8640).

<~dgw> ;tld md
<&Kaede> [tld] The top-level domain 'md' exists, but no details about it could be found.
<~dgw> ,tld md
<SopelTest> [tld] Name: .md | Entity: Moldova | DNSSEC: Yes | SLD: Yes | Notes: Restricted to individuals
            or companies with a physical address in Moldova.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label May 27, 2021
@dgw dgw added this to the 7.1.0 milestone May 27, 2021
@dgw dgw requested a review from a team May 27, 2021 07:15
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't tested that myself, the code itself looks sound. So I'm OK with that.

@dgw dgw merged commit ca8ebcc into master May 28, 2021
@dgw dgw deleted the tld-cctld-fix branch May 28, 2021 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants