Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tld: fix .tldcache clear command breaking .tld until manual update #2077

Merged
merged 1 commit into from
May 31, 2021
Merged

tld: fix .tldcache clear command breaking .tld until manual update #2077

merged 1 commit into from
May 31, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented May 29, 2021

Description

Tin. Using del bot.memory[key] is not safe; the keys used by this plugin must be reset to their default values.

Workaround in 7.1.0 is to run .tldcache update immediately after .tldcache clear, or to run ONLY the update subcommand.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

This is what I get for trying to be cute with the loop-based approach.

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label May 29, 2021
@dgw dgw added this to the 7.1.1 milestone May 29, 2021
@dgw dgw requested a review from a team May 29, 2021 23:33
Exirel
Exirel approved these changes May 30, 2021
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dgw
tld: fix .tldcache clear command breaking .tld until manual update
7fb3b26 
Workaround in 7.1.0 is to run `.tldcache update` immediately after
`.tldcache clear`, or to run ONLY the `update` subcommand.
@dgw dgw force-pushed the tld-cache-clear branch from 7d7f41f to 7fb3b26 Compare May 31, 2021 03:31
@dgw
Copy link
Member Author

dgw commented May 31, 2021

Got the checks all sorted via no-op force-push (git commit --amend --no-edit) but need to think for a sec about how I want to handle "backporting" to 7.1.x.

Will probably end up either cherry-picking or creating a "Backports" PR for each maintenance release.

@dgw dgw merged commit 269498a into master May 31, 2021
@dgw dgw deleted the tld-cache-clear branch May 31, 2021 17:51
dgw added a commit that referenced this pull request May 31, 2021
@dgw
tld: fix .tldcache clear command breaking .tld until manual update
ea92fee 
Workaround in 7.1.0 is to run `.tldcache update` immediately after
`.tldcache clear`, or to run ONLY the `update` subcommand.

Note: Backport of #2077 for 7.1.x branch.
(7fb3b26)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel