config: fix BooleanAttribute default=True #2084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes
default=True
work correctly forBooleanAttribute
s - see: url.py not working in 7.1.0.I'm not sure why that stub was overridden, but I can't think of a reason BoolAttr would need to behave differently from the normal
BaseValidated._parse()
. @dgw?Includes lazy test of default default and default=True. It might belong in test/config/test_config_types.py but that's harder and I'm out of time and brain to melt.
Checklist
make qa
(runsmake quality
andmake test
)