Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tell: use correct verb when tellee == bot.nick; use NICKLEN if available #2106

Merged
merged 2 commits into from
Jun 19, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 16, 2021

Description

This is one trivial tweak plus one trivial bugfix bundled into one PR, because it would be extremely silly to make two.

  • Fixed a TODO that should have been done for 7.1.0: use NICKLEN from bot.isupport
  • Fixed hardcoded "tell" in the error message when tellee == bot.nick

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • Note that this is not tested code, so I only used make quality
  • I have tested the functionality of the things this change touches

@dgw dgw added Tweak Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Jun 16, 2021
@dgw dgw added this to the 7.1.1 milestone Jun 16, 2021
@dgw dgw requested a review from a team June 16, 2021 06:33
@dgw dgw merged commit 8d00051 into master Jun 19, 2021
@dgw dgw deleted the tell-tweaks branch June 19, 2021 00:40
dgw added a commit that referenced this pull request Jun 19, 2021
Backport of pull request #2106 for 7.1.1. Corresponds to a merge commit
on the `master` branch: 8d00051
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants