Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugins.rules.URLCallback: use yield from expression #2124

Merged
merged 1 commit into from
Jul 6, 2021
Merged

plugins.rules.URLCallback: use yield from expression #2124

merged 1 commit into from
Jul 6, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jun 28, 2021

Description

We have dropped support for Python 2, and this eliminates yet another TODO comment left in the code.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
plugins.rules.URLCallback: use yield from expression
aa52a39 
We have dropped support for Python 2, and this eliminates yet another
TODO comment left in the code.
@dgw dgw added this to the 8.0.0 milestone Jun 28, 2021
@dgw dgw requested a review from a team June 28, 2021 03:43
@dgw dgw mentioned this pull request Jun 28, 2021
Closed
3 tasks
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jul 5, 2021
@dgw dgw merged commit e3bdf17 into master Jul 6, 2021
@dgw dgw deleted the URLCallback-yield-from branch July 6, 2021 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Low Priority Tweak
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel