Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translate: catch requests exceptions #2153

Merged
merged 1 commit into from
Jul 10, 2021
Merged

translate: catch requests exceptions #2153

merged 1 commit into from
Jul 10, 2021

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jul 9, 2021

Description

Tin (fix #2152).

Also I added some logging, because why not.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jul 9, 2021
@Exirel Exirel added this to the 7.1.2 milestone Jul 9, 2021
@Exirel Exirel force-pushed the translate-error-handling branch from 07cb535 to 12af23d Compare July 9, 2021 21:41
@Exirel Exirel force-pushed the translate-error-handling branch from 12af23d to a5d4928 Compare July 9, 2021 21:46
dgw
dgw approved these changes Jul 10, 2021
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the one hand, requests.exceptions.Timeout could be handled by the same except block as its parent class requests.exceptions.RequestException. But it's not bad to handle it separately and put more info in the error sent to IRC.

@dgw dgw merged commit 1b5c207 into sopel-irc:master Jul 10, 2021
dgw pushed a commit that referenced this pull request Jul 10, 2021
@Exirel @dgw
translate: catch requests exceptions
a61bbd9 
This is #2153, cherry-picked back to 7.1.x by @dgw.
@Exirel Exirel deleted the translate-error-handling branch December 31, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
7.1.2
Development

Successfully merging this pull request may close these issues.

Unhandled exception in translate plugin
2 participants
@Exirel @dgw