Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: skip messagebox template contents #2159

Merged
merged 1 commit into from
Aug 5, 2021
Merged

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 14, 2021

Description

It took me literally ten minutes to write and test this, albeit not that thoroughly. Should fix #2158, though the reason I opened that issue is I thought it would take more effort/time…

Demo

<Sopel 7.1.2> [wikipedia] Gurmukhi - Letters | "This article contains IPA phonetic symbols. Without proper
              rendering support, you may see question marks, boxes, or other symbols instead of Unicode
              characters. For an introductory guide on IPA symbols, see Help:IPA. The Gurmukhī alphabet contains
              thirty-five base letters (akkhara, plural akkharā̃), traditionally arranged in seven rows of five
              letters each. The first three letters, or mātarā vāhak ("vowel carrier"), […]"
<This PR> [wikipedia] Gurmukhi - Letters | "The Gurmukhī alphabet contains thirty-five base letters (akkhara,
          plural akkharā̃), traditionally arranged in seven rows of five letters each. The first three letters, or
          mātarā vāhak ("vowel carrier"), are distinct because they form the basis for vowels and are not
          consonants, or vianjan, like the remaining letters are, and except for the second letter aiṛā are never
          used on their own; see § […]"

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jul 14, 2021
@dgw dgw added this to the 7.1.3 milestone Jul 14, 2021
@dgw dgw requested a review from a team July 14, 2021 05:55
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dgw dgw merged commit 6ac286b into master Aug 5, 2021
@dgw dgw deleted the wikipedia-skip-messagebox branch August 5, 2021 16:17
dgw added a commit that referenced this pull request Aug 5, 2021
wikipedia: skip messagebox template contents

Cherry-picked from master @ 6ac286b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wikipedia: Message boxes are included in snippet
2 participants