Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isupport: maintain PREFIX ordering #2200

Merged
merged 1 commit into from
Nov 30, 2021

Conversation

half-duplex
Copy link
Member

Description

Fixes #2198 by no longer sorting PREFIX entries and returning an OrderedDict.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex force-pushed the isupport-prefix-order branch from 8f1fbea to 0848282 Compare October 24, 2021 22:52
@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Oct 24, 2021
@dgw dgw added this to the 8.0.0 milestone Oct 25, 2021
@dgw dgw requested a review from Exirel October 25, 2021 02:23
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we drop python 3.6

Soon.

@dgw dgw merged commit 03b5cae into sopel-irc:master Nov 30, 2021
@half-duplex half-duplex deleted the isupport-prefix-order branch November 30, 2021 23:33
@half-duplex half-duplex restored the isupport-prefix-order branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isupport.PREFIX is not ordered
3 participants