Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

coretasks: alert owner if nick in RPL_WELCOME does not match config #2215

Merged
merged 1 commit into from
Dec 1, 2021
Merged

coretasks: alert owner if nick in RPL_WELCOME does not match config #2215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions sopel/coretasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,29 @@ def startup(bot, trigger):
if bot.connection_registered:
return

# nick shenanigans are serious business, but fortunately RPL_WELCOME
# includes the actual nick used by the server after truncation, removal
# of invalid characters, etc. so we can check for such shenanigans
if trigger.event == events.RPL_WELCOME:
if bot.nick != trigger.args[0]:
# setting modes below is just one of the things that won't work
# as expected if the conditions for running this block are met
privmsg = (
"Hi, I'm your bot, %s. The IRC server didn't assign me the "
"nick you configured. This can cause problems for me, and "
"make me do weird things. You'll probably want to stop me, "
"figure out why my nick isn't acceptable, and fix that before "
"starting me again." % bot.nick
)
debug_msg = (
"RPL_WELCOME indicated the server did not accept the bot's "
"configured nickname. Requested '%s'; got '%s'. This can "
"cause unexpected behavior. Please modify the configuration "
"and restart the bot." % (bot.nick, trigger.args[0])
)
LOGGER.critical(debug_msg)
bot.say(privmsg, bot.config.core.owner)

# set flag
bot.connection_registered = True

Expand Down