url: bring additional sanity and calm to log output #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sky is not falling if this plugin can't connect to a found URL, nor is it The End Of The World As We Know It if a title isn't found. These are debug/info events, not errors/warnings.
4 tasks
dgw
added a commit
that referenced
this pull request
Feb 12, 2022
url: bring additional sanity and calm to log output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sky is not falling if this plugin can't connect to a found URL, nor is it The End Of The World As We Know It if a title isn't found.
These are debug/info events, not errors/warnings.
Checklist
make qa(runsmake qualityandmake test)Notes
This is not marked as a resolution of #2207 because it doesn't technically address the core problem reported there. If sent to IRC as described, the "Traceback" can still become "part of [the] url". I will touch
IrcLoggingHandlerin a separate PR to address that.