Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Python EOL warnings #2298

Merged
merged 1 commit into from
Jun 8, 2022
Merged

Remove Python EOL warnings #2298

merged 1 commit into from
Jun 8, 2022

Conversation

SnoopJ
Copy link
Contributor

@SnoopJ SnoopJ commented Jun 8, 2022

Description

This PR corrects the warning message emitted by Sopel when running on Python prior to 3.8 to give the correct EOL for CPython 3.7

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added this to the 8.0.0 milestone Jun 8, 2022
@half-duplex half-duplex changed the title Cite correct EOL date for Python 3.7 in emitted warnings Remove Python EOL warnings Jun 8, 2022
@SnoopJ SnoopJ force-pushed the update-warning-text branch from 3b6c9e5 to da67b6a Compare June 8, 2022 17:26
dgw
dgw approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously approve for the reasons given on IRC, lol.

Exirel
Exirel approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That feels good.

@dgw dgw merged commit e38942e into sopel-irc:master Jun 8, 2022
@dgw dgw added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jun 8, 2022
@SnoopJ SnoopJ deleted the update-warning-text branch June 8, 2022 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

@half-duplex half-duplex half-duplex approved these changes

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SnoopJ @dgw @half-duplex @Exirel