Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: fix various type error #2307

Merged
merged 1 commit into from
Jun 11, 2022
Merged

url: fix various type error #2307

merged 1 commit into from
Jun 11, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jun 11, 2022

Description

Making mypy happy with url.py.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added the Housekeeping Code cleanup, removal of deprecated stuff, etc. label Jun 11, 2022
@Exirel Exirel added this to the 8.0.0 milestone Jun 11, 2022
@Exirel Exirel requested a review from half-duplex June 11, 2022 16:53
@Exirel Exirel marked this pull request as ready for review June 11, 2022 16:53
half-duplex
half-duplex approved these changes Jun 11, 2022
View reviewed changes
sopel/modules/url.py Show resolved Hide resolved
@dgw dgw merged commit e93e470 into sopel-irc:master Jun 11, 2022
@Exirel Exirel deleted the fix-url-type-checking branch July 14, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@half-duplex half-duplex half-duplex approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Exirel @half-duplex @dgw