-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
seen: catch database write errors #2338
seen: catch database write errors #2338
Conversation
Are you running Also this whole patch makes me wish that (Did someone say, "Add transactions to the key/value API? 🙃) |
Possibly. I don't know what the right version is, it doesn't appear to be one of the things pinned by test.log
|
Ah, there are dev-only requirements (not needed at runtime) in At present, my recommended way to get started from scratch is (from the top level of the
That should make sure you have the necessary versions of everything. If you still have problems with the tests after that, maybe try collaboratively debugging on IRC with whoever is around tomorrow (me, Exirel, etc.). |
D'oh! That's the very obvious thing I'd missed.
Sounds good, I can stop making a fool of myself with QA on each PR 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better than nothing. I'm sure this will piss off people using Channel Logging, but it's still better than replying with errors for every message. So yeah, that's good to me.
@SnoopJeDi Can you squash, and remove the "fixes" notation? |
ef0a3d0
to
c83da4a
Compare
Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
c83da4a
to
fbfb8e0
Compare
Description
Currently, if the DB writes that the
seen
plugin tries to do fail for any reason, the error will propagate up intobot.error()
and cause very antisocial error report messages from the bot every time the channel receives messages, if thereply_errors
(sic) feature is turned on. In particular, I've seen this with a disk that becomes full with thesqlite3
backend, but this patch should cover a broad class of such failures.Checklist
make qa
(runsmake quality
andmake test
)make qa
againstmaster
(0479737):12 failed, 1268 passed, 8 xfailed, 1 warning, 73 errors in 44.38s