-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wikipedia: support query strings in Wikipedia URLs #2414
wikipedia: support query strings in Wikipedia URLs #2414
Conversation
I am foolish for not looking more closely at this earlier. Why not use the parsed URL for the fragment, also? Are you trying to avoid touching too much? If you change the URL pattern to (Not a review comment because I'm just trying to understand the intended scope; Exi's comment you referenced was about converting all of the link-matching logic to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're updating comments anyway...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's the right moment to push a little further the cleanup of the plugin and remove the use of sopel.tools.web.unquote
when it's literally just a shortcut for the stdlib urllib.parse.unquote
.
Edit: actually, same for sopel.tools.web.quote
. Both are useless now.
Alright, all that is left is a squash, since @dgw approved and I checked the changes. I don't think there is enough to require more than one commit, and I don't mind if you lose the co-author from my suggestions (I don't assume you know, but you might, all that to say it's up to you). |
…2412) Co-authored-by: dgw <dgw@technobabbl.es> Co-authored-by: Florian Strzelecki <florian.strzelecki@gmail.com>
2e759af
to
9229c20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have put changing the existing imports from sopel.tools.web
as out of scope for this, but it doesn't ultimately matter. The quote
and unquote
wrappers there have comments that we should consider deprecating them, anyway.
Description
This PR fixes #2412 by discarding the query string from the name of the article to be searched.
Checklist
make qa
(runsmake quality
andmake test
)