Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload: remove .update command #2416

Merged
merged 1 commit into from
Mar 3, 2023
Merged

reload: remove .update command #2416

merged 1 commit into from
Mar 3, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Feb 28, 2023

Description

Sopel's not designed to run directly from a Git working directory any more, so let's not advertise this command that relies upon it.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches
    • It was really easy to test, because this only removes stuff.

@dgw dgw added Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Feb 28, 2023
@dgw dgw added this to the 8.0.0 milestone Feb 28, 2023
@dgw dgw requested a review from a team February 28, 2023 17:35
@dgw
reload: remove .update command
c743925 
Sopel's not designed to run directly from a Git working directory any
more, so let's not advertise this command that relies upon it.
@dgw dgw force-pushed the reload-rm-update-cmd branch from 8b293ea to c743925 Compare February 28, 2023 17:40
Exirel
Exirel approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍 😍 😍 😍

@Exirel Exirel mentioned this pull request Mar 3, 2023
Closed
@dgw dgw closed this Mar 3, 2023
@dgw dgw reopened this Mar 3, 2023
@dgw
Copy link
Member Author

dgw commented Mar 3, 2023

(How dumb do you have to be to click "close" instead of "merge"? At least as dumb as me, I guess.)

@dgw dgw merged commit 10bc3ed into master Mar 3, 2023
@dgw dgw deleted the reload-rm-update-cmd branch March 3, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @Exirel