ip: remove plugin extracted to external package #2523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnoopJ
added
the
Breaking Change
dgw
requested changes
Oct 14, 2023
dgw
changed the title
dgw
changed the title
dgw
approved these changes
Oct 14, 2023
SnoopJ
force-pushed
the
feature/use-external-iplookup
branch
2 times, most recently
from
54e08a1 to
0752ff8
Compare
|
We've published sopel-iplookup 1.0.0. I had a soft-block on this being merged before publication, despite @SnoopJ's "YOLO" above, but the plugin's up now so |
|
I'd ideally like the removal to be a single operation, deleting the plugin and its requirement in one go. I'd also like the Coveralls check statuses to report properly… They're getting stuck on Pending a lot lately and it always seems to be on commits that don't touch any code. 🤔 |
SnoopJ
force-pushed
the
feature/use-external-iplookup
branch
from
bd1e6f1 to
e4c5166
Compare
Rebased, should be the case now.
Yea, dunno what's going on with them 🤷 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the built-in
ipplugin in favor of the newly packageizedsopel-iplookupplugin, as part of #1291. Note that since #2504 hasn't landed yet, I'm still using the oldermodulesterminology here, but if that PR lands first, this one should be reworked to use the new terminology.This should not be merged untilEdit: YOLO merge whenever I guesssopel-iplookuphas been uploaded to PyPI.I have marked this as a breaking change because, per discussion on IRC, we decided that it makes sense for the new package to name the plugin
iplookuprather than the more genericip. If users mentionipin their bot configuration (i.e. to exclude it), they will need to change the name to account for that.Checklist
make qa(runsmake lintandmake test)