tell: avoid errors produced by empty tellee #2584
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset is an alternative to #2582 that transforms the
tellee
as early as possible.The use of
lstrip("@")
in this patch means that an arbitrary number of prefixing@
s will be removed, so that@@Someone
is transformed intoSomeone
where it would previously have been transformed to@Someone
, but since this is an edge case to begin with, I don't think it's any problem.Longer term, we'd like to have better awareness of if
tellee
is a valid nick or not. I've filed #2583 for this purpose.Checklist
make qa
(runsmake lint
andmake test
)