Feat/current location nearest station #13 #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mst-mkt
requested changes
Nov 5, 2024
Deploying sophie with
|
| Latest commit: |
00eb7ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://07b9c363.sophie-4ce.pages.dev |
| Branch Preview URL: | https://feat-currentlocation-nearest.sophie-4ce.pages.dev |
mst-mkt
requested changes
Nov 5, 2024
imoken777
force-pushed
the
feat/currentLocation_nearestStation_#13
branch
from
8a79f9d to
605228c
Compare
mst-mkt
reviewed
Nov 7, 2024
Comment on lines
10
to
17
| const a = | ||
| Math.sin(deltaLatitude / 2) * Math.sin(deltaLatitude / 2) + | ||
| Math.cos(degreeToRadian(from.lat)) * | ||
| Math.cos(degreeToRadian(to.lat)) * | ||
| Math.sin(deltaLongitude / 2) * | ||
| Math.sin(deltaLongitude / 2) | ||
|
|
||
| const c = 2 * Math.atan2(Math.sqrt(a), Math.sqrt(1 - a)) |
There was a problem hiding this comment.
公式か何かを使った複雑な計算は、コメントアウトで補足しておいたほうがわかりやすそう
There was a problem hiding this comment.
関数分けるとよりわかりずらそうだったから関数にjsdocと途中計算にはコメントアウトにした
それでもよくわからないけど
mst-mkt
approved these changes
Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #13
backend
stationUseCaseに最寄り駅取得メソッドgetNearestStation追加/location追加frontend