[Fix] #103 - 로그인뷰 1차 QA (레이아웃 조정) #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devxsby
requested review from
L-j-h-c,
yangsubinn and
lsj8706
and removed request for
L-j-h-c
yangsubinn
approved these changes
Jan 12, 2023
Comment on lines
146
to
152
| public func showNetworkAlert() { | ||
| let alertVC = AlertVC(alertType: .networkErr) | ||
| .setTitle(I18N.Default.networkError, I18N.Default.networkErrorDescription) | ||
| alertVC.modalPresentationStyle = .overFullScreen | ||
| alertVC.modalTransitionStyle = .crossDissolve | ||
| self.present(alertVC, animated: true) | ||
| } |
There was a problem hiding this comment.
따로 생성하지 않구 ModuleFactory에 makeNetworkAlertVC 가져다가 바로 사용하셔두 될 것 같아여
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
이어 받아서 구현한 내용
📸 스크린샷
📮 관련 이슈