Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #129- github codeowners 추가 #130

Merged
merged 1 commit into from
Mar 19, 2023
Merged

[Feat] #129- github codeowners 추가 #130

merged 1 commit into from
Mar 19, 2023

Conversation

devxsby
Copy link
Member

@devxsby devxsby commented Mar 19, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • 소소하지만 풀리퀘 작성시 다섯명을 다 리뷰어 등록하기 귀찮아서 2기 iOS 챕터원들을 코드리뷰어를 자동으로 지정해주는 작업을 했어요.

📌 참고 사항

  • merge 작업 후에 다른 세팅한 거랑 적용이 잘 되는지 테스트해볼 수 있겠어요... 커밋은 1개 뿐입니다요

📸 스크린샷

이런식으로 풀리퀘에 팀으로 직접 리뷰어 지정해도 돼요~!

스크린샷 2023-03-19 13 57 38

📮 관련 이슈

@devxsby devxsby added Setting 프로젝트 세팅, 라이브러리 설치 윤수🥚 labels Mar 19, 2023
@devxsby devxsby requested a review from a team March 19, 2023 04:59
@devxsby devxsby self-assigned this Mar 19, 2023
@devxsby devxsby requested review from elesahich, 0inn and lsj8706 and removed request for a team March 19, 2023 04:59
@devxsby devxsby requested review from a team and L-j-h-c and removed request for a team March 19, 2023 05:00
0inn
0inn approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@0inn 0inn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

L-j-h-c
L-j-h-c approved these changes Mar 19, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋네요~~! 감사합니다!

lsj8706
lsj8706 approved these changes Mar 19, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다~~!!

@devxsby devxsby merged commit 17c5829 into sopt-makers:develop Mar 19, 2023
@elesahich
Copy link
Contributor

늦었지만~! 감사합니다~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@0inn 0inn 0inn approved these changes

@elesahich elesahich Awaiting requested review from elesahich elesahich was automatically assigned from sopt-makers/ios-chapter-2nd

Assignees

@devxsby devxsby

Labels
Setting 프로젝트 세팅, 라이브러리 설치 size/XS 윤수🥚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Setting] automatically assign code reviewer
5 participants
@devxsby @elesahich @0inn @L-j-h-c @lsj8706