Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #150 - SOPTamp Dismiss 기능 추가 #162

Merged
merged 2 commits into from
Apr 16, 2023
Merged

[Feat] #150 - SOPTamp Dismiss 기능 추가 #162

merged 2 commits into from
Apr 16, 2023

Conversation

L-j-h-c
Copy link
Contributor

@L-j-h-c L-j-h-c commented Apr 16, 2023

🌴 PR 요약

🌱 작업한 브랜치

SOPTamp Dismiss 기능을 추가했습니다.

📮 관련 이슈

@L-j-h-c L-j-h-c requested a review from a team April 16, 2023 08:40
@L-j-h-c L-j-h-c self-assigned this Apr 16, 2023
@L-j-h-c L-j-h-c requested review from elesahich, 0inn, lsj8706 and devxsby and removed request for a team April 16, 2023 08:40
0inn
0inn approved these changes Apr 16, 2023
View reviewed changes
SOPT-iOS/Projects/Modules/DSKit/Sources/Components/SoptampComponents/STNavigationBar.swift
@@ -153,6 +158,28 @@ extension STNavigationBar {
titleButton.showsMenuAsPrimaryAction = true
return self
}

@discardableResult
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 warning을 안띄워줄 수 있는 이런 애도 있었네요 . .? 굳 👍🏻

lsj8706
lsj8706 approved these changes Apr 16, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!!👍

@L-j-h-c L-j-h-c merged commit 8475149 into sopt-makers:develop Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

@0inn 0inn 0inn approved these changes

@elesahich elesahich Awaiting requested review from elesahich elesahich was automatically assigned from sopt-makers/ios-chapter-2nd

@devxsby devxsby Awaiting requested review from devxsby devxsby was automatically assigned from sopt-makers/ios-chapter-2nd

Assignees

@L-j-h-c L-j-h-c

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 솝탬프 닫기 기능 추가
3 participants
@L-j-h-c @0inn @lsj8706