-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #17 - CustomNavigationBar 수정, typoStyle 추가 #18
[Fix] #17 - CustomNavigationBar 수정, typoStyle 추가 #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니당 🫶🏻
저희 근데 라이트모드랑 세로모드고정도 되어있나여?
안되어있으면 요기 브랜치에서 같이 작업하는것은 어떠할까여,,??!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오아 너무 편리하네여...감사합니다!!
Merge branch 'develop' of https://github.com/sopt-makers/SOPT-Stamp-iOS into fix/sopt-makers#17-CustomNavigationBar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다👍
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
1️⃣ TypoStyle
TypoStyle은 이미 들어가있던 타이포 스타일 외에 두개만 추가했습니다(caption1D, caption2D)
피그마의 디자인 시스템 내에서는 타이포 이름에 _(언더바)하고 weight랑 size가 추가되어있는데,
저희가 사용할 때는 _(언더바) 뒷부분은 무시하고 보시면 될 것 같습니다
ex)
h1_b20
->h1
cap1_r14
->caption1
cap1_d_m14
->caption1D
2️⃣ CustomNavigationBar
setRightButton(_ type: rightButtonType)
에서 설정해서 사용할 수 있습니다사용예시
네비바 종류가 크게 달라지지 않을 것 같아서 이 세개만 있다는 가정하에 분류했습니다
📌 참고 사항
📸 스크린샷
📮 관련 이슈