-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] #207- 출석조회 레이아웃 수정 #208
The head ref may contain hidden characters: "fix/#207-\uCD9C\uC11D\uC870\uD68C\uB808\uC774\uC544\uC6C3\uC218\uC815"
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드 확인했습니다 ~ 고생하셨습니다 . .
로딩뷰는 제가 다시 손보겠습니다 ㅎㅎ
하단 출석하기 버튼은 hidden 처리는 되는데 layout이 업데이트가 안되는거죠 ??
이것도 손보겠습니다 ..^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~!!
if let url = URL(string: "https://sopt.org/rules") { | ||
UIApplication.shared.open(url) | ||
} | ||
let safariViewController = SFSafariViewController(url: URL(string: "https://sopt.org/rules")!) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 링크도 따로 빼서 관리하는 게 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
어디에 넣을지 어정쩡해서 일단 그대로 뒀어요. ㅠ
다음에 웹링크만 따로 모아서 정리하는 작업을 해보도록 해요! 🙌🏻
setDefaultLayout() | ||
|
||
dateLabel.text = date | ||
placeLabel.text = place | ||
titleLabel.text = I18N.Attendance.today + todaySchedule + I18N.Attendance.dayIs | ||
titleLabel.partFontChange(targetString: todaySchedule, | ||
font: DSKitFontFamily.Suit.bold.font(size: 18)) | ||
subtitleLabel.text = description | ||
subtitleLabel.isHidden = ((description?.isEmpty) == nil || description == "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description?.isEmpty == nil 인 경우는 어떤 경우일까요?
description == nil 이랑 차이가 없을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
경고 뜨는거 누르고 누르다가 바꼈습니다 호호 . . .
- info 버튼 클릭 직 후 토스트 메시지 추가 - 기타 잔잔바리 ..
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
(지금 출석 버튼이 안보이는 때에도 영역이 잡혀서 하단에 검정색 부분으로 조금 잘리네요..!)
📸 스크린샷
📮 관련 이슈