Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] LifecycleAdapter 위치 이동 : SOPT-iOS 모듈로 이동 #319

Merged
merged 2 commits into from
Dec 3, 2023
Merged

[Fix] LifecycleAdapter 위치 이동 : SOPT-iOS 모듈로 이동 #319

merged 2 commits into from
Dec 3, 2023

Conversation

elesahich
Copy link
Contributor

@elesahich elesahich commented Dec 3, 2023 •
edited
Loading

🌴 PR 요약

#309 의 후속 작업이여요, LifecycleAdapter의 위치 변경 PR이에요

🌱 작업한 브랜치

  • fix/relocate-adapter

🌱 PR Point

  1. 이게 가용한 옵션은 SOPT-iOS 메인 모듈밖에 없겠더라고요!
  2. 그렇답니다. 나머지는 안 되고, 나중을 고려했을때도 이 장소가 맞을 것 같아요~ (e.g. 소켓 유실, 인터넷 유실 처리 등)

📌 참고 사항

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

  • Resolved: #

@elesahich elesahich added bug Something isn't working 승호 🐶 labels Dec 3, 2023
@elesahich elesahich self-assigned this Dec 3, 2023
lsj8706
lsj8706 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다!! 👍

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 3, 2023
@elesahich elesahich merged commit 120052a into sopt-makers:develop Dec 3, 2023
@elesahich elesahich deleted the fix/relocate-adapter branch December 3, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

Assignees

@elesahich elesahich

Labels
bug Something isn't working size/M 승호 🐶
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elesahich @lsj8706