-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] NotificationList: 디테일 액션 챙기기 완료 #342
Merged
elesahich
merged 4 commits into
sopt-makers:develop
from
elesahich:feature/finishies-notification-list-detail
Dec 27, 2023
Merged
[Feature] NotificationList: 디테일 액션 챙기기 완료 #342
elesahich
merged 4 commits into
sopt-makers:develop
from
elesahich:feature/finishies-notification-list-detail
Dec 27, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elesahich
force-pushed
the
feature/finishies-notification-list-detail
branch
from
December 27, 2023 12:41
2c0811e
to
e4b4d36
Compare
elesahich
changed the title
[Feature] NotificationList:
[Feature] NotificationList: 디테일 액션 챙기기 완료
Dec 27, 2023
lsj8706
approved these changes
Dec 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment on lines
+65
to
+69
let verifyIsNewlyAddedFriend = { | ||
guard user.isFirstMeet else { return false } | ||
|
||
return user.isFirstMeet && userModel.isFirstMeet == false | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
야무지네요!
elesahich
force-pushed
the
feature/finishies-notification-list-detail
branch
from
December 27, 2023 13:15
e4b4d36
to
b68b8fd
Compare
땡큐! 수정 완료잉 |
elesahich
force-pushed
the
feature/finishies-notification-list-detail
branch
from
December 27, 2023 13:20
b68b8fd
to
75dfa25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
Poke NotificationList 미비된 작업을 마무리 합니다 : 대상은 아래와 같아요
(잠수함 패치) bottomSheet의 api 호출 타이밍 : viewWillAppear > viewDidLoaded.
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
📸 스크린샷
📮 관련 이슈