Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] NotificationList: 디테일 액션 챙기기 완료 #342

Conversation

elesahich
Copy link
Contributor

🌴 PR 요약

Poke NotificationList 미비된 작업을 마무리 합니다 : 대상은 아래와 같아요

  • Poke 연결
  • GET poke/to/me/list paginated query 적용
  • 새로운 친구 : Lottie 노출
  • PUT /poke : API fail인 경우 toast를 노출

(잠수함 패치) bottomSheet의 api 호출 타이밍 : viewWillAppear > viewDidLoaded.

🌱 작업한 브랜치

  • feature/#finishes-notification-list-detail

🌱 PR Point

📌 참고 사항

📸 스크린샷

Simulator Screen Recording - iPhone 15 Pro - 2023-12-27 at 20 34 04

📮 관련 이슈

  • Resolved: #

@elesahich elesahich added Feat 새로운 기능 구현 승호 🐶 labels Dec 27, 2023
@elesahich elesahich self-assigned this Dec 27, 2023
@elesahich elesahich force-pushed the feature/finishies-notification-list-detail branch from 2c0811e to e4b4d36 Compare December 27, 2023 12:41
@elesahich elesahich changed the title [Feature] NotificationList: [Feature] NotificationList: 디테일 액션 챙기기 완료 Dec 27, 2023
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~~!!!

image

(현재 화면)

(피그마 화면)

혹시 여기 네비바 부분 색상이 조금 다른 것 같은데 확인해주실 수 있나요~~?

Comment on lines +65 to +69
let verifyIsNewlyAddedFriend = {
guard user.isFirstMeet else { return false }

return user.isFirstMeet && userModel.isFirstMeet == false
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

야무지네요!

@elesahich elesahich force-pushed the feature/finishies-notification-list-detail branch from e4b4d36 to b68b8fd Compare December 27, 2023 13:15
@elesahich
Copy link
Contributor Author

땡큐! 수정 완료잉

@elesahich elesahich force-pushed the feature/finishies-notification-list-detail branch from b68b8fd to 75dfa25 Compare December 27, 2023 13:20
@elesahich elesahich merged commit 5cc3282 into sopt-makers:develop Dec 27, 2023
@elesahich elesahich deleted the feature/finishies-notification-list-detail branch December 27, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 새로운 기능 구현 size/L 승호 🐶
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants