[Fix] Poke 3차 QA 리스트 반영 #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elesahich
force-pushed
the
fix/qa-list-3
branch
from
d052429 to
5d46914
Compare
lsj8706
approved these changes
Jan 10, 2024
Comment on lines
+144
to
+152
| private extension String { | ||
| func applyMDSFont() -> NSMutableAttributedString { | ||
| self.applyMDSFont( | ||
| height: 22.f, | ||
| font: DSKitFontFamily.Suit.medium.font(size: 16), | ||
| color: DSKitAsset.Colors.gray30.color, | ||
| letterSpacing: 0.f | ||
| ) | ||
| } |
There was a problem hiding this comment.
MDS 폰트 관련해서 공통 모듈로 빼면 좋을 것 같네요!
There was a problem hiding this comment.
저도 그렇게 생각합니다~~~~~~ 요건 .text를 모두 attributedText로 대치 해야 해요!!!!! (ㅎㅎ)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
3차 QA 리스트를 반영했어요
🌱 작업한 브랜치
🌱 PR Point
팀-앱 Slack : 잔여 업무 정리
📌 참고 사항
📸 스크린샷
📮 관련 이슈