Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat]#13- 온보딩, 로그인 뷰 구현 #40

Merged
merged 6 commits into from
Dec 8, 2022
Merged

[Feat]#13- 온보딩, 로그인 뷰 구현 #40

merged 6 commits into from
Dec 8, 2022

Conversation

devxsby
Copy link
Member

@devxsby devxsby commented Dec 8, 2022 •
edited
Loading

🌴 PR 요약

  • 온보딩, 로그인 뷰 구현

🌱 작업한 브랜치

🌱 PR Point

  • CustomTextFieldView의 textfield return type done으로 추가하고 textFieldShouldReturn 메서드로 resignFirstResponder 등록좀했습니다.

📌 참고 사항

  • PageControl 커스텀하는 거는 이슈 따로 파서 하겠습니당.

📸 스크린샷

iPhone 13 mini

Simulator Screen Recording - iPhone 13 mini - 2022-12-08 at 19 03 33

iPhone SE 3rd generation

Simulator Screen Recording - iPhone SE (3rd generation) - 2022-12-08 at 19 10 59

📮 관련 이슈

@devxsby devxsby added the Feat 새로운 기능 구현 label Dec 8, 2022
@devxsby devxsby self-assigned this Dec 8, 2022
lsj8706
lsj8706 approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

깔끔하네요 수고하셨습니다~~👍

SOPT-Stamp-iOS/Projects/Data/Sources/Repository/SignInRepository.swift
public class SignInRepository {

private let networkService: AuthService
private let cancelBag = Set<AnyCancellable>()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CancelBag으로 통일하면 좋을 것 같아요~!

SOPT-Stamp-iOS/Projects/Modules/DSKit/Sources/Components/CustomTextFieldView.swift
@@ -430,4 +431,9 @@ extension CustomTextFieldView: UITextFieldDelegate {
isEmpty ? self.setTextFieldViewState(.normal) : self.setTextFieldViewState(.editing)
}
}

public func textFieldShouldReturn(_ textField: UITextField) -> Bool {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍

L-j-h-c
L-j-h-c approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빠르게 많은 뷰를 구현하셨네여👍 👍 ...! 수고하셨습니다~~!

@devxsby devxsby merged commit c177675 into sopt-makers:develop Dec 8, 2022
@devxsby devxsby deleted the feat/#13-로그인뷰구현 branch December 8, 2022 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsj8706 lsj8706 lsj8706 approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@yangsubinn yangsubinn Awaiting requested review from yangsubinn

Assignees

@devxsby devxsby

Labels
Feat 새로운 기능 구현 size/XL 윤수🥚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 로그인 뷰 구현
3 participants
@devxsby @L-j-h-c @lsj8706