Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #42 - ListDetail scrollView로 레이아웃 수정(se 기기대응) #44

Merged
merged 3 commits into from
Dec 11, 2022
Merged

[Fix] #42 - ListDetail scrollView로 레이아웃 수정(se 기기대응) #44

merged 3 commits into from
Dec 11, 2022

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • naviBar 제외하고 전체 scrollView로 변경
  • se 기기 대응

📌 참고 사항

scrollView에 넣으면서 아래로 스크롤하는 제스처 관련된 부분은 지웠습니다.
키보드 관련 애니메이션도 UIView.animate는 삭제하고, scrollView.setContentOffset(.zero, animated: true) 사용해서 작성해줬습니다

📸 스크린샷

기능 스크린샷
se(3rd generation) ezgif com-gif-maker (90)

📮 관련 이슈

@yangsubinn yangsubinn added Fix 문제 해결, 코드 수정 양수🌷 labels Dec 10, 2022
@yangsubinn yangsubinn self-assigned this Dec 10, 2022
devxsby
devxsby approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@devxsby devxsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오웅. 고생하셨습니다!!! 🙇🏻‍♀️

L-j-h-c
L-j-h-c approved these changes Dec 10, 2022
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당!

@yangsubinn yangsubinn merged commit 06d7016 into sopt-makers:develop Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devxsby devxsby devxsby approved these changes

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@lsj8706 lsj8706 Awaiting requested review from lsj8706

Assignees

@yangsubinn yangsubinn

Labels
Fix 문제 해결, 코드 수정 size/M 양수🌷
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 글 작성(수정) 뷰 se 기기대응
3 participants
@yangsubinn @L-j-h-c @devxsby