[Feat] #54 - 랭킹 리스트 뷰 비즈니스 로직 구현 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om:L-j-h-c/SOPT-Stamp-iOS into feature/sopt-makers#54-RankingBusiness
lsj8706
approved these changes
Dec 23, 2022
| @@ -23,5 +23,9 @@ public class RankingRepository { | |||
| } | |||
|
|
|||
| extension RankingRepository: RankingRepositoryInterface { | |||
|
|
|||
| public func fetchRankingListModel() -> AnyPublisher<[Domain.RankingModel], Error> { | |||
| return Future<[RankingModel], Error> { promise in | |||
There was a problem hiding this comment.
오우 거대한 더미 데이터.. 만드느라 수고하셨습니다..!
devxsby
approved these changes
Dec 23, 2022
Comment on lines
28
to
29
| ? userId! | ||
| : 1 |
| } | ||
|
|
||
| extension ChartRectangleView { | ||
| static func == (left: ChartRectangleView, right: ChartRectangleView) -> Bool { |
| @@ -66,7 +66,7 @@ public extension BaseService { | |||
| // MARK: - MakeRequests | |||
|
|
|||
| extension BaseService { | |||
| func requestObjectInCombine<T: Decodable>(_ target: API) -> AnyPublisher<T?, Error> { | |||
| func requestObjectInCombine<T: Decodable>(_ target: API) -> AnyPublisher<T, Error> { | |||
…feature/sopt-makers#54-RankingBusiness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
랭킹 리스트 뷰의 비즈니스 로직 구현했습니다. Service는 아직 서버가 구현되지 않아 더미데이터를 보내고 있습니다.
랭킹 미션 리스트 뷰로의 화면전환 로직을 구현했습니다.
추후 말풍선 디자인 변경되면 1, 2, 3위의 화면전환 로직도 구현하겠습니다.
📮 관련 이슈