-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] #61 - 스탬프 삭제, 초기화 Domain, Data 및 Network 구현 #65
[Feat] #61 - 스탬프 삭제, 초기화 Domain, Data 및 Network 구현 #65
Conversation
Merge branch 'develop' of https://github.com/sopt-makers/SOPT-Stamp-iOS into feat/sopt-makers#61-DeleteStampNetwork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AlertVC 만들어주신 거 잘 사용하겠습니다 ㅎㅎ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다 슨상님...!
let subject = PassthroughSubject<Int, Error>() | ||
requestObjectWithNoResult(StampAPI.deleteStamp(stampId: stampId)) { result in | ||
result.success { statusCode in | ||
subject.send(statusCode ?? 0) | ||
} | ||
} | ||
return subject.eraseToAnyPublisher() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오...혹시 요렇게 구현해야했던 이유가 있을까요...? 아래에 주석이 있길래...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아이고 이거 지우고 아래꺼 주석 풀어서 올리겠슴다 !
combine으로 된게 없는 줄 알고 저러케 했었는데 있어서 수정했다가 .. 머 해본다구 주석 걸고 고대로 올렸나봐여 .. 😅
.sink { success in | ||
if success { | ||
self.showToast(message: I18N.Setting.resetSuccess) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요기에는 filter를 사용해도 좋을 것 같네용~~!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
네넹 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다 빙수선배. 🤍
Merge branch 'develop' of https://github.com/sopt-makers/SOPT-Stamp-iOS into feat/sopt-makers#61-DeleteStampNetwork
🌴 PR 요약
🌱 작업한 브랜치
🌱 PR Point
📌 참고 사항
🚨앞의 풀리퀘 #62 머지한 다음에 봐주세여 ! 커밋이 포함되어 있어서 조금 정신 없을 수 있습니다 ..
AlertVC에 type별로 분리했습니다
네트워크 오류 alert의 경우
아래처럼 바로 factory에서 불러서 사용하시면 됩니다
그 외의 alert를 사용하는 경우
📸 스크린샷
📮 관련 이슈