Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] #63 - 설정뷰 서비스 이용 방침 추가 #69

Merged
merged 7 commits into from
Jan 1, 2023
Merged

[Feat] #63 - 설정뷰 서비스 이용 방침 추가 #69

merged 7 commits into from
Jan 1, 2023

Conversation

devxsby
Copy link
Member

@devxsby devxsby commented Jan 1, 2023

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • I18N Setting에 추가하려다 너무 길어서 serviceUsagePolicy 따로 만들어서 제일 마지막에 추가했어요.
  • 텍스트 뷰로 만들고 복사 붙여넣기 막아두고, 스크롤 인디케이터 바 안보이도록 했어요.

📌 참고 사항

  • 대분류 소분류가 폰트가 똑같아서 보기 힘든데 수정할까욥..?

📸 스크린샷

개인정보처리방침 서비스 이용약관
Simulator Screen Shot - iPhone 13 mini - 2023-01-01 at 19 36 06 Simulator Screen Shot - iPhone 13 mini - 2023-01-01 at 19 36 16

📮 관련 이슈

@devxsby devxsby added Feat 새로운 기능 구현 윤수🥚 labels Jan 1, 2023
@devxsby devxsby self-assigned this Jan 1, 2023
L-j-h-c
L-j-h-c approved these changes Jan 1, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

화면전환이 없는 뷰라서 factory에 관한 부분은 지워도 될 것 같아요! 수고하셨습니다~~!

SOPT-Stamp-iOS/Projects/Presentation/Sources/SettingScene/VC/PrivacyPolicyVC.swift
Comment on lines +80 to +82
public func textViewDidChangeSelection(_ textView: UITextView) {
textView.selectedTextRange = nil
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

요기는 어떤 이유로 넣으셨나용...? isUserInteractionEnabled를 false로 주는것과 결과가 다를까요?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제가 약관들을 텍스트뷰로 넣었는데 isUserInteractionEnabled 값을 false로 주면 스크롤이 막혀서 밑에 부분까지 안넘어가요...
그래서 복사 붙여넣기 막는 용도로 textViewDidChangeSelection 메서드 추가했어요!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devxsby 그렇군요!! 수고하셨습니다~~

lsj8706
lsj8706 approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@lsj8706 lsj8706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~!

yangsubinn
yangsubinn approved these changes Jan 1, 2023
View reviewed changes
Copy link
Member

@yangsubinn yangsubinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨슴니다~!~!

대분류 소분류 폰트가 똑같다는게 '제 1조' 이런게 폰트가 같아서 눈에 안띈다는거신가여?
gui 보니까 텍스트뷰 안에 타이포가 일부 다르긴 하더라구여 ..!

요거 말하는거 맞으면 이거 반영해주면 될거같은데 이게 쫌 번거로울거같기도 해서 ..
기디만 괜찮다면 그냥 동일한 폰트로 유지하는 것두 ....... 괜찮지 않으까 ..... 싶었슴니다

스크린샷 2023-01-01 오후 10 13 48

스크린샷 2023-01-01 오후 10 13 37

@devxsby
Copy link
Member Author

devxsby commented Jan 1, 2023

@yangsubinn 윤정씨가 괜찮다고 합니다링, ,일단 그대로 갈게요! 감삼다 !!

@devxsby devxsby merged commit 0c01f6a into sopt-makers:develop Jan 1, 2023
@devxsby devxsby deleted the feat/#63-설정뷰서비스이용방침 branch January 1, 2023 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@yangsubinn yangsubinn yangsubinn approved these changes

@lsj8706 lsj8706 lsj8706 approved these changes

Assignees

@devxsby devxsby

Labels
Feat 새로운 기능 구현 size/L 윤수🥚
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feat] 설정 뷰 서비스 이용방침 추가
4 participants
@devxsby @L-j-h-c @lsj8706 @yangsubinn