Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] #92 - 글 상세 edit으로 타입 변경시, changeTitle로 타이틀 변경 #93

Closed
wants to merge 3 commits into from
Closed

[Fix] #92 - 글 상세 edit으로 타입 변경시, changeTitle로 타이틀 변경 #93

wants to merge 3 commits into from

Conversation

yangsubinn
Copy link
Member

🌴 PR 요약

🌱 작업한 브랜치

🌱 PR Point

  • CustomButton changeTitle 메서드 수정
  • sceneType 변경시 setUI 내에서 changeTitle 호출

📌 참고 사항

이전 풀리퀘 #91 커밋이 포함되어 있는데, 이번 이슈에 대한 커밋이 하나 뿐이라 해당 커밋 눌러서 봐주시면 감사하겠습니다~!

📸 스크린샷

기능 스크린샷
기능이름 스크린샷 첨부

📮 관련 이슈

@yangsubinn yangsubinn added Fix 문제 해결, 코드 수정 양수🌷 labels Jan 8, 2023
@yangsubinn yangsubinn self-assigned this Jan 8, 2023
L-j-h-c
L-j-h-c approved these changes Jan 8, 2023
View reviewed changes
Copy link
Contributor

@L-j-h-c L-j-h-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@pull-request-size pull-request-size bot added size/S and removed size/M labels Jan 8, 2023
@yangsubinn
Merge pull request sopt-makers#93 from yangsubinn/fix/sopt-makers#92
eaef7eb 
[Fix] sopt-makers#92 - 글 상세 edit으로 타입 변경시, changeTitle로 타이틀 변경
@yangsubinn yangsubinn closed this Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-j-h-c L-j-h-c L-j-h-c approved these changes

@lsj8706 lsj8706 Awaiting requested review from lsj8706

@devxsby devxsby Awaiting requested review from devxsby

Assignees

@yangsubinn yangsubinn

Labels
Fix 문제 해결, 코드 수정 size/S 양수🌷
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fix] 스탬프 등록 후 수정시 하단 버튼 타이틀 '미션 완료'로 유지되는 문제 해결
2 participants
@yangsubinn @L-j-h-c