feat #725: code clear

sopt-makers · Jun 8, 2024 · d8a7f2e · d8a7f2e
1 parent f47ddea
commit d8a7f2e
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 12 deletions.
diff --git a/.../java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt b/.../java/org/sopt/official/feature/poke/friend/detail/FriendListDetailBottomSheetFragment.kt
@@ -139,9 +139,10 @@ class FriendListDetailBottomSheetFragment : BottomSheetDialogFragment() {
                             anonymousFriend?.let {
                                 tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName)
                                 tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name)
-                                it.profileImage.takeIf { image ->
-                                    image.isNotEmpty()
-                                }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } }
+                                imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) {
+                                    transformations(CircleCropTransformation())
+                                }
+
                                 imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage)
                             }
 

diff --git a/.../src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt b/.../src/main/java/org/sopt/official/feature/poke/friend/summary/FriendListSummaryActivity.kt
@@ -130,9 +130,10 @@ class FriendListSummaryActivity : AppCompatActivity() {
                             anonymousFriend?.let {
                                 tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName)
                                 tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name)
-                                it.profileImage.takeIf { image ->
-                                    image.isNotEmpty()
-                                }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } }
+                                imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) {
+                                    transformations(CircleCropTransformation())
+                                }
+
                                 imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage)
                             }
 

diff --git a/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt b/feature/poke/src/main/java/org/sopt/official/feature/poke/main/PokeMainActivity.kt
@@ -164,9 +164,10 @@ class PokeMainActivity : AppCompatActivity() {
                             anonymousFriend?.let {
                                 tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName)
                                 tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name)
-                                it.profileImage.takeIf { image ->
-                                    image.isNotEmpty()
-                                }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } }
+                                imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) {
+                                    transformations(CircleCropTransformation())
+                                }
+
                                 imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage)
                             }
 

diff --git a/...oke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt b/...oke/src/main/java/org/sopt/official/feature/poke/notification/PokeNotificationActivity.kt
@@ -132,9 +132,10 @@ class PokeNotificationActivity : AppCompatActivity() {
                             anonymousFriend?.let {
                                 tvAnonymousFreindName.text = getString(R.string.anonymous_user_identity, it.anonymousName)
                                 tvAnonymousFreindInfo.text = getString(R.string.anonymous_user_info, it.generation, it.part, it.name)
-                                it.profileImage.takeIf { image ->
-                                    image.isNotEmpty()
-                                }.run { imgAnonymousFriendOpen.load(this) { transformations(CircleCropTransformation()) } }
+                                imgAnonymousFriendOpen.load(it.profileImage.ifEmpty { R.drawable.ic_empty_profile }) {
+                                    transformations(CircleCropTransformation())
+                                }
+
                                 imgAnonymousFriendOpenOutline.setRelationStrokeColor(it.mutualRelationMessage)
                             }