Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/makers-design-system] Makers Design System (Current Version) #595

Merged
merged 11 commits into from
Mar 2, 2024

Conversation

l2hyunwoo
Copy link
Member

What is this issue?

@l2hyunwoo l2hyunwoo self-assigned this Mar 2, 2024
@l2hyunwoo l2hyunwoo requested a review from a team as a code owner March 2, 2024 08:56
Copy link

height bot commented Mar 2, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@l2hyunwoo l2hyunwoo marked this pull request as draft March 2, 2024 09:48
Comment on lines 111 to +130
onPrimary,
background,
onBackground,
backgroundDimmed,
surface,
success,
error,
information,
attention,
onSurface,
onSurface95,
onSurface90,
onSurface80,
onSurface70,
onSurface60,
onSurface950,
onSurface900,
onSurface800,
onSurface700,
onSurface600,
onSurface500,
onSurface400,
onSurface300,
onSurface200,
onSurface100,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy는 기존 copy 보다는 깊은 복사의 느낌으로 이해하면 될까요 ??

Copy link
Contributor

@giovannijunseokim giovannijunseokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

벌써 MDS 드릉드릉하네요 ㅎㅎ 고생하셨습니다 ~!!!

@pull-request-size pull-request-size bot added size/XL and removed size/L labels Mar 2, 2024
@l2hyunwoo l2hyunwoo marked this pull request as ready for review March 2, 2024 10:28
@l2hyunwoo l2hyunwoo force-pushed the feature/makers-design-system branch from 7a4621d to e3b6037 Compare March 2, 2024 12:56
@l2hyunwoo l2hyunwoo merged commit ac9ee41 into develop Mar 2, 2024
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/makers-design-system branch March 2, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants