Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature/apply-lifecycle-service] Service에 Lifecycle 적용하기 #671

Merged
merged 2 commits into from
Apr 19, 2024
Merged

[feature/apply-lifecycle-service] Service에 Lifecycle 적용하기 #671

merged 2 commits into from
Apr 19, 2024

Conversation

l2hyunwoo
Copy link
Member

What is this issue?

  • 기존 LifecycleService 코드를 활용해서 FirebaseMessagingService에 Lifecycle 적용하고 내부 CoroutineScope을 lifecycleScope으로 활용해서 만들기

Reference

@l2hyunwoo l2hyunwoo requested a review from a team as a code owner April 17, 2024 14:28
@height Height
Copy link

height bot commented Apr 17, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@l2hyunwoo l2hyunwoo force-pushed the feature/apply-lifecycle-service branch from 5c5c98d to 088acb4 Compare April 17, 2024 16:18
@l2hyunwoo l2hyunwoo force-pushed the feature/apply-lifecycle-service branch from 088acb4 to 0f29819 Compare April 18, 2024 06:09
giovannijunseokim
giovannijunseokim approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@giovannijunseokim giovannijunseokim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
리뷰 한 번씩 확인해주시면 감사하겠습니다 ~!

@l2hyunwoo
Copy link
Member Author

l2hyunwoo commented Apr 19, 2024 •
edited
Loading

@giovannijunseokim @chattymin 다음 정기 출시 전에 QA 필요

@l2hyunwoo l2hyunwoo merged commit b065e68 into develop Apr 19, 2024
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/apply-lifecycle-service branch April 19, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannijunseokim giovannijunseokim giovannijunseokim approved these changes

Assignees

@l2hyunwoo l2hyunwoo

Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l2hyunwoo @giovannijunseokim