Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

피드 상세 댓글 좋아요 영역 UI 구현 방식 수정과 모바일 대응 #412

Merged
merged 2 commits into from
Sep 17, 2023
Merged

피드 상세 댓글 좋아요 영역 UI 구현 방식 수정과 모바일 대응 #412

merged 2 commits into from
Sep 17, 2023

Conversation

borimong
Copy link
Contributor

@borimong borimong commented Sep 16, 2023 •
edited
Loading

🚩 관련 이슈

📋 작업 내용

  • 피드 상세 댓글 좋아요 영역 UI 구현 방식 수정과 모바일 대응

📌 PR Point

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 댓글 부분과 좋아요 부분을 하나의 div 로 감싸주고, width 를 지정해 줌으로써 댓글 및 좋아요 수에 관계없이 내용이 중앙 정렬되게 해주었습니다.
  • 어떤 위험이나 우려가 발견되었는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 개발하면서 어떤 점이 궁금했는지

📸 스크린샷

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Sep 16, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: a8227d4
Status:⚡️  Build in progress...

View logs

@borimong borimong temporarily deployed to development September 16, 2023 17:22 — with GitHub Actions Inactive
@borimong borimong self-assigned this Sep 16, 2023
@borimong borimong temporarily deployed to development September 17, 2023 05:12 — with GitHub Actions Inactive
@borimong borimong marked this pull request as ready for review September 17, 2023 05:15
@eunsukimme eunsukimme changed the base branch from feat/#394 to develop September 17, 2023 05:38
eunsukimme
eunsukimme approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@eunsukimme eunsukimme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생했어~ 👍

@borimong borimong merged commit 7161948 into develop Sep 17, 2023
1 check was pending
@eunsukimme eunsukimme deleted the feat/#401 branch September 17, 2023 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunsukimme eunsukimme eunsukimme approved these changes

@na-reum na-reum Awaiting requested review from na-reum

@100Gyeon 100Gyeon Awaiting requested review from 100Gyeon

Assignees

@borimong borimong

Labels
size/S size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

피드 상세 댓글 좋아요 영역 UI 구현 방식 수정과 모바일 대응
2 participants
@borimong @eunsukimme