-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] 최종 QA 반영 #281
Merged
Merged
[Fix] 최종 QA 반영 #281
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
9c47ba7
fix: 이메일 인증번호 전송 라이팅 수정
lydiacho e3c4992
fix: 이전기수활동여부 해당사항없음 제거
lydiacho 399e3c2
fix: 동아리를 알게된경로 제거
lydiacho 89caca7
fix: 지원서 헤더 배경영역 재지정
lydiacho f3c2746
fix: placeholer prop optional로 수정
lydiacho fc27ac2
fix: 이메일 인증전송 라이팅 축약
lydiacho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
글자가 너무 많아진 거 같아요
네트워크로 인해 약 1분 정도 -> 네트워크 지연 등이 아닌 네트워크 자체는 원인이 아닌 거 같아요
약 1분 이후 메일이 오지 않는다면 -> 위의 약 1분 정도와 문구가 겹치는 거 같아요
따라서
이메일이 전송되었어요. 약 1분 정도 소요될 수 있어요.
메일이 오지 않는다면 스팸 메일함을 확인해주세요.
로 변경하는 거 어떠신가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 디자인쪽에서 정해주신 거라서 슬랙으로 논의 옮길게요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
요 문구로 픽스돼서 반영했습니다~~~