fix: S3 FileKey 파싱 오류 수정 & CrewService 이전기수 하드코딩 현재 구조로 수정 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
softmoca
reviewed
Jan 17, 2025
Comment on lines
-38
to
+36
| public Integer getStudyCount(Integer generation) { | ||
| val activeGen = (generation != null) ? generation : PREV_GEN; | ||
| val active = !activeGen.equals(PREV_GEN); | ||
|
|
||
| val crewApiResponse = crewClient.getAllStudy(1, 1, activeGen, active, studyCategory); | ||
| public Integer getStudyCount(Integer generation, boolean isActive) { | ||
| val crewApiResponse = crewClient.getAllStudy(1, 1, generation, isActive, studyCategory); |
There was a problem hiding this comment.
앗 크루쪽도 하드 코딩된 기수 값이 있었네요 !!
반영해 주셔서 감사합니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
관련 이슈가 있다면 적어주세요.
📌 개발 이유
💻 수정 사항
→ S3 파일키가 잘못 파싱되어서 발생 ⇒ 수정완료
→ 현재 이전기수 회귀식으로 적용되도록 수정
🧪 테스트 방법
⛳️ 고민한 점 || 궁굼한 점
🎯 리뷰 포인트
📁 레퍼런스