Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SP0] 에러페이지 QA 반영 #381

Merged
merged 3 commits into from
Mar 26, 2024
Merged

[SP0] 에러페이지 QA 반영 #381

merged 3 commits into from
Mar 26, 2024

Conversation

lydiacho
Copy link
Member

Summary

Comment

QA 사항 두가지 반영했습니다

특히 모바일 브라우저의 자체 탭 때문에 view height가 달라져서
100vh를 의도했으나 원치않는 스크롤이 발생하는 경우가 많은데요
이럴 때는 vh 단위를 dvh (dynamic view height)로 바꿔주면 사파리 등 탭 사이즈가 동적인 브라우저의 view height도 잘 대응해주게 됩니다

@lydiacho lydiacho added this to the 4기 milestone Mar 24, 2024
@lydiacho lydiacho requested a review from eonseok-jeon March 24, 2024 17:11
@lydiacho lydiacho self-assigned this Mar 24, 2024
Copy link

height bot commented Mar 24, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@eonseok-jeon eonseok-jeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~ ◡̈

추가로 vw, vh 관련 좋은 글 있어서 공유합니다~

@lydiacho lydiacho merged commit 81f9cb2 into develop Mar 26, 2024
1 check passed
@lydiacho lydiacho deleted the feat/#380_error-qa branch March 26, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SP0] 에러페이지 QA사항 반영
2 participants