Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons optimization #1207

Merged
merged 1 commit into from
Oct 30, 2023
Merged

icons optimization #1207

merged 1 commit into from
Oct 30, 2023

Conversation

RustemYuzlibaev
Copy link
Contributor

No description provided.

@RustemYuzlibaev RustemYuzlibaev changed the title remove css and if-statement icons optimization Oct 30, 2023
fill: var(--s-color-base-content-secondary) !important;
.el-menu-item {
i.el-icon-bank-card {
width: 28px;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size=28 prop instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2023-10-30 at 19 50 18

it's already like so, it has no effect. The structure is a bit different when el-icons

@RustemYuzlibaev RustemYuzlibaev merged commit bd66c12 into develop Oct 30, 2023
@RustemYuzlibaev RustemYuzlibaev deleted the fix/optimize-icon-appearance branch October 30, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants